Something about the Triangle.class

[ruizi]

Something about the Triangle.class in the package of org.avmframework.examples.inputdatageneration.triangle

From Line 33 to Line 37, if it is in the scenario of num1 being equal to num2 but num2 is not equal to num3, the logic will regard the triangle as SCALENE, but actually, it should be ISOSCELES (num1 = num2).

[nikhilty]

This works as it should

1. If num1 == num2 & num2 == num3 - Then type is EQUILATERAL.
2. Else If num1 == num2 - Then Type is ISOSCELES
3. Else if num2 == num3 - Then type is ISOSCELES

[ruizi]

If you go through the code logic at line 35 with the example of (num1 = 3, num2 = 3 and num3 = 1) then, the code will output SCALENE. But actually, the triangle is ISOSCELES

[ruizi]

It will not go into the else logic starting from line 38.

[Kianzahrai]

I created a test file in avmf\src\test\java\org\avmframework\examples\inputdatageneration\triangle\ with the following test case (among others):

...
    @Test
    public void testBranch6F_isoscelesNotEquilateral {
        // Branch 6F: num2 != num3 (when num1 == num2)
        // Input: (3, 3, 1)
        // Expected: ISOSCELES (implicit, type remains SCALENE from line 80)
        TriangleType result = Triangle.classify(3, 3, 1);
        assertEquals(TriangleType.ISOSCELES, result);
    }
...

When running the file (as a JUnit Test), it did in fact pass (result of test case matched with ISOSCELES). It does not return SCALENE when line 35 is executed,

However, I do think that there is something up with the logic implemented; noticing the first if statement for num1 == num2 on line 34, if the outcome of this check is false, the program would instead go to the else statement on line 38. The following if statement on line 39 is where the issue lies. In terms of coverage, this line of code will never be reached (branch 7 True or 7T), hence it may be redundant to include. I understand why it is implemented as such, but just wanted to bring my thoughts on it.

P.S., the mention of branching in the code is to do with the branch ID argument, trying to test which branches can be covered with diferrent test cases, hence the intention behind this test file and its test cases.