From a61760b0252711cbb68ca7e7b25943b1dcd8c3c2 Mon Sep 17 00:00:00 2001 From: Martinski4GitHub <119833648+Martinski4GitHub@users.noreply.github.com> Date: Thu, 26 Mar 2026 23:44:56 -0700 Subject: [PATCH] Minor code improvements Just minor code improvements. --- README.md | 4 ++-- uiScribe.sh | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 909e3af..ef17ebe 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # uiScribe -## v1.4.13 -### Updated on 2026-Mar-02 +## v1.4.14 +### Updated on 2026-Mar-26 ## About uiScribe updates the System Log page to show log files created by Scribe (syslog-ng). Requires [**Scribe**](https://github.com/cynicastic/scribe) diff --git a/uiScribe.sh b/uiScribe.sh index eba370e..c8f739e 100644 --- a/uiScribe.sh +++ b/uiScribe.sh @@ -13,7 +13,7 @@ ## Forked from https://github.com/jackyaz/uiScribe ## ## ## ######################################################## -# Last Modified: 2026-Mar-02 +# Last Modified: 2026-Mar-26 #------------------------------------------------------- ########### Shellcheck directives ########## @@ -29,8 +29,8 @@ ### Start of script variables ### readonly SCRIPT_NAME="uiScribe" -readonly SCRIPT_VERSION="v1.4.13" -readonly SCRIPT_VERSTAG="26030223" +readonly SCRIPT_VERSION="v1.4.14" +readonly SCRIPT_VERSTAG="26032623" SCRIPT_BRANCH="develop" SCRIPT_REPO="https://raw.githubusercontent.com/AMTM-OSR/$SCRIPT_NAME/$SCRIPT_BRANCH" readonly SCRIPT_DIR="/jffs/addons/${SCRIPT_NAME}.d" @@ -1506,13 +1506,11 @@ ScriptHeader() ##----------------------------------------## MainMenu() { - Create_Dirs - Create_Symlinks printf " WebUI for %s is available at:\n ${SETTING}%s${CLRct}\n\n" "$SCRIPT_NAME" "$(Get_WebUI_URL)" printf " ${GRNct}1${CLRct}. Customise list of logs displayed by %s\n\n" "$SCRIPT_NAME" printf " ${GRNct}rf${CLRct}. Clear user preferences for displayed logs\n\n" - printf " ${GRNct}u${CLRct}. Check for updates\n" + printf " ${GRNct}u${CLRct}. Check for new version updates\n" printf " ${GRNct}uf${CLRct}. Force update %s with latest version\n\n" "$SCRIPT_NAME" printf " ${GRNct}e${CLRct}. Exit %s\n\n" "$SCRIPT_NAME" printf " ${GRNct}z${CLRct}. Uninstall %s\n" "$SCRIPT_NAME" @@ -1529,6 +1527,7 @@ MainMenu() if Check_Lock menu then Generate_Log_List + Create_Symlinks printf "\n" Clear_Lock else @@ -1858,7 +1857,8 @@ if [ $# -eq 0 ] || [ -z "$1" ] then NTP_Ready Entware_Ready - if grep -qF '/dev/null' "$userCheckLogList" + if [ -s "$userCheckLogList" ] && \ + grep -qF '/dev/null' "$userCheckLogList" then sed -i '/\/dev\/null/d' "$userCheckLogList" fi