Fix compilation error on master: Using getter#619
Closed
jonasschwab wants to merge 1 commit into
Closed
Conversation
jonasschwab
requested review from
Copilot,
fassaad and
johanneshofmann87
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a compilation error introduced by the runtime-variable accessor refactor by replacing direct references to LTAU, LOBS_ST, and LOBS_EN with their getter functions in Prog/main.F90.
Changes:
- Update the
tau_pcall site to passget_LOBS_ST()/get_LOBS_EN()instead ofLOBS_ST/LOBS_EN. - Update the surrounding conditional to use
get_Ltau()(case-insensitive call written asget_LTAU()).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Lol Jonas and I were again doing the same thing in parallel. I guess this issue is now already taken care and we can close this issue WITHOUT merging is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The combination of #609 and #566 introduced a compiler error, since
get_LTAU(),get_LOBS_ST()andget_LOBS_EN()have to be used instead ofLTAU,LOBS_STandLOBS_EN.