Skip to content

Commit 0d514fa

Browse files
committed
fix: preserve dismissed status on review request upsert
The upsert was resetting dismissed reviews back to pending on every GitHub poll, immediately undoing the user's dismiss action. Also enlarged the dismiss button click target for easier interaction.
1 parent f08864c commit 0d514fa

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

apps/server/src/persistence/Layers/ReviewRequestRepository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ const makeReviewRequestRepository = Effect.gen(function* () {
127127
pr_title = ${row.prTitle},
128128
author_login = ${row.authorLogin},
129129
is_bot = ${row.isBot},
130-
status = CASE WHEN review_requests.status IN ('dismissed', 'approved', 'changes_requested') THEN 'pending' ELSE review_requests.status END,
130+
status = CASE WHEN review_requests.status IN ('approved', 'changes_requested') THEN 'pending' ELSE review_requests.status END,
131131
pr_body = ${row.prBody},
132132
pr_labels = ${row.prLabels},
133133
updated_at = ${row.updatedAt}

apps/web/src/components/NotificationBell.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,11 +331,11 @@ export default function NotificationBell({
331331
</div>
332332
<button
333333
type="button"
334-
className="mt-0.5 shrink-0 rounded p-0.5 text-muted-foreground/40 opacity-0 transition-opacity hover:bg-secondary hover:text-foreground group-hover/item:opacity-100"
334+
className="shrink-0 self-start rounded p-1.5 text-muted-foreground/40 opacity-0 transition-opacity hover:bg-secondary hover:text-foreground group-hover/item:opacity-100"
335335
aria-label="Dismiss"
336336
onClick={(event) => void handleDismiss(event, request.id)}
337337
>
338-
<XIcon className="size-3" />
338+
<XIcon className="size-3.5" />
339339
</button>
340340
</div>
341341
</div>

0 commit comments

Comments
 (0)