-
-
Notifications
You must be signed in to change notification settings - Fork 92
Description
Body:
Environment:
OS: Windows 11
Python: 3.12.10
ComfyUI Version: v0.11.1
Hardware: NVIDIA RTX 5090
Description : I am reporting a severe installation blocking issue on Windows with Python 3.12. Both ComfyUI-RMBG and ComfyUI-SDPose rely on groundingdino (or groundingdino-py).
The current requirements.txt forces an installation from source (git source), which attempts to compile C++ CUDA extensions. This fails catastrophically on Windows systems without a full Visual Studio C++ build environment, throwing subprocess-exited-with-error and No module named 'torch' inside the isolated build environment.
This creates a conflict where users cannot install either node successfully via ComfyUI-Manager.
Error Log:
Plaintext
× Getting requirements to build wheel did not run successfully.
│ exit code: 1
╰─> [30 lines of output]
ModuleNotFoundError: No module named 'torch'
...
RuntimeError: Error compiling objects for extension
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip.
ERROR: Failed building wheel for groundingdino
Steps to Reproduce
Use a fresh ComfyUI Portable (or venv) with Python 3.12 on Windows.
Try to install ComfyUI-RMBG or SDPose via Manager.
Installation hangs and fails during the wheel building process for GroundingDINO.
My Solution: I had to manually bypass the requirements file and install a pre-compiled wheel found in the community: pip install https://github.com/jtydhr88/ComfyUI-GroundingDINO/releases/download/v0.1.0/groundingdino-0.1.0-cp312-cp312-win_amd64.whl
Suggestion: Please consider:
Updating requirements.txt to detect Windows environments and point to a pre-compiled wheel instead of the raw git repository.
Or providing a specific install.py script that handles the binary installation for Windows users to prevent this "Dependency Hell."