From 5374436ceb4c90165b59b3eabebc0a5b866f29f6 Mon Sep 17 00:00:00 2001 From: 0m364 <13804150+0m364@users.noreply.github.com> Date: Fri, 26 Jun 2026 10:58:50 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=8E=A8=20Palette:=20[a11y]=20Make=20sitre?= =?UTF-8?q?p=20anchor=20tags=20accessible=20as=20modal=20buttons?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 💡 What: Added `role="button"` and `aria-haspopup="dialog"` to `#sitrep-btn` links and enabled keyboard activation via spacebar. 🎯 Why: Using `` tags for modals confuses screen readers and prevents keyboard users from triggering them with the spacebar. 📸 Before/After: Visuals unchanged; interactions significantly improved for keyboard users. ♿ Accessibility: Ensures the element is correctly identified as a modal-triggering button and supports full keyboard functionality (Space/Enter). --- .Jules/palette.md | 4 ++++ concepts.html | 2 +- contact.html | 2 +- modal.js | 6 ++++++ products.html | 2 +- 5 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.Jules/palette.md b/.Jules/palette.md index 7c7c523..0ec0517 100644 --- a/.Jules/palette.md +++ b/.Jules/palette.md @@ -29,3 +29,7 @@ ## 2026-06-12 - Robust Skip-to-Content Links **Learning:** Adding a "Skip to main content" link is a critical accessibility requirement for keyboard users. To make it robust, it needs to be hidden visually but appear when focused using `transform: translateY(-100%)` instead of magic pixel numbers, and the target container (e.g., `
`) must have a matching `id` and `tabindex="-1"` so it can programmatically receive focus across all browsers. **Action:** Always include a visually hidden 'Skip to main content' link immediately after the opening `` tag. Set the main content container with an `id` and explicitly `tabindex="-1"`. + +## 2024-05-24 - Trigger Anchor Tags for Modals +**Learning:** Using `` tags with `href="#"` to open modals fails to correctly communicate the element's purpose to screen readers and is fundamentally inaccessible for keyboard users who rely on the spacebar to activate buttons. +**Action:** When using `` tags to trigger modals, enforce accessibility by adding `role="button"` and `aria-haspopup="dialog"`. Additionally, bind a `keydown` event listener for the spacebar (`e.key === ' ' || e.key === 'Spacebar'`), explicitly calling `e.preventDefault()` to stop page scrolling before executing the modal open logic. diff --git a/concepts.html b/concepts.html index d4e1807..13b8873 100644 --- a/concepts.html +++ b/concepts.html @@ -19,7 +19,7 @@

CHARLES WILLIAMS

Products Concepts Contact - OSINT + OSINT
diff --git a/contact.html b/contact.html index b30b503..15d119b 100644 --- a/contact.html +++ b/contact.html @@ -49,7 +49,7 @@

Get in Touch

- + OSINT diff --git a/modal.js b/modal.js index 994d6bd..7ad7852 100644 --- a/modal.js +++ b/modal.js @@ -56,6 +56,12 @@ const openModal = (e) => { const btns = document.querySelectorAll('#sitrep-btn'); btns.forEach(btn => { btn.addEventListener('click', openModal); + btn.addEventListener('keydown', (e) => { + if (e.key === ' ' || e.key === 'Spacebar') { + e.preventDefault(); + openModal(e); + } + }); }); // Close modal via button diff --git a/products.html b/products.html index f5f0835..01f1a6c 100644 --- a/products.html +++ b/products.html @@ -20,7 +20,7 @@

CHARLES WILLIAMS

Products Concepts Contact - OSINT + OSINT