From e7ad878ff20bb466c36993040e397a6dc1a4e0f1 Mon Sep 17 00:00:00 2001 From: 0m364 <13804150+0m364@users.noreply.github.com> Date: Thu, 25 Jun 2026 11:09:12 +0000 Subject: [PATCH] feat(a11y): add role and Spacebar support to modal triggers Update OSINT/Sitrep modal trigger anchor tags across concepts.html, contact.html, and products.html to use `role="button"` and `aria-haspopup="dialog"`. Add `keydown` event listener in `modal.js` to support triggering the modal via the `Spacebar` key for keyboard users and screen readers, preventing default page scrolling. Documented learning in `.Jules/palette.md`. --- .Jules/palette.md | 4 ++++ concepts.html | 2 +- contact.html | 2 +- modal.js | 6 ++++++ products.html | 2 +- 5 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.Jules/palette.md b/.Jules/palette.md index 7c7c523..6a27cd9 100644 --- a/.Jules/palette.md +++ b/.Jules/palette.md @@ -29,3 +29,7 @@ ## 2026-06-12 - Robust Skip-to-Content Links **Learning:** Adding a "Skip to main content" link is a critical accessibility requirement for keyboard users. To make it robust, it needs to be hidden visually but appear when focused using `transform: translateY(-100%)` instead of magic pixel numbers, and the target container (e.g., `
`) must have a matching `id` and `tabindex="-1"` so it can programmatically receive focus across all browsers. **Action:** Always include a visually hidden 'Skip to main content' link immediately after the opening `` tag. Set the main content container with an `id` and explicitly `tabindex="-1"`. + +## 2026-06-25 - Anchor Tag Buttons and Spacebar Accessibility +**Learning:** When using `` tags (with `href="#"`) as buttons to trigger actions like opening a modal, they lack the correct semantic meaning and keyboard support. While screen readers will read them as links, and native anchor tags trigger on `Enter`, screen readers and keyboard users expect buttons to respond to both `Enter` and `Spacebar`. Without `Spacebar` support, the default page scrolling action occurs, breaking the user experience. +**Action:** Always add `role="button"` and `aria-haspopup="dialog"` when using `` tags as buttons for modals. Additionally, bind a JavaScript `keydown` event listener for the `Spacebar` key (using `e.preventDefault()` to stop default page scrolling), as native anchors only trigger on `Enter`. diff --git a/concepts.html b/concepts.html index d4e1807..13b8873 100644 --- a/concepts.html +++ b/concepts.html @@ -19,7 +19,7 @@

CHARLES WILLIAMS

Products Concepts Contact - OSINT + OSINT
diff --git a/contact.html b/contact.html index b30b503..15d119b 100644 --- a/contact.html +++ b/contact.html @@ -49,7 +49,7 @@

Get in Touch

- + OSINT diff --git a/modal.js b/modal.js index 994d6bd..ea4a2ec 100644 --- a/modal.js +++ b/modal.js @@ -56,6 +56,12 @@ const openModal = (e) => { const btns = document.querySelectorAll('#sitrep-btn'); btns.forEach(btn => { btn.addEventListener('click', openModal); + btn.addEventListener('keydown', (e) => { + if (e.key === ' ') { + e.preventDefault(); + openModal(e); + } + }); }); // Close modal via button diff --git a/products.html b/products.html index f5f0835..01f1a6c 100644 --- a/products.html +++ b/products.html @@ -20,7 +20,7 @@

CHARLES WILLIAMS

Products Concepts Contact - OSINT + OSINT